Conversation
thecrypticace
changed the title
thecrypticace
force-pushed
the
feat/better-internals
branch
2 times, most recently
from
97eefe0 to
57b6f6c
Compare
thecrypticace
force-pushed
the
feat/better-internals
branch
from
57b6f6c to
da51992
Compare
It stopped being used with Prettier v3
Boshen
force-pushed
the
feat/better-internals
branch
from
0fc721e to
0ad1b29
Compare
Collaborator
|
@Dunqing reviewed the code and confirmed this works with Prettier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two large-ish issues with the current implementation of this plugin:
parsemethod of builtin plugins and third party plugins to call the original and walk + mutate the AST. We should instead override the printer and perform the sorting then.This PR addresses the first one and prepares for the 2nd one with a pretty extensive internal refactor.
It's likely that this PR, once done, can be released in the v0.7.x series. While no breaking changes are intended (or anticipated) moving sorting logic to the print stage that should probably be a v0.8.x since things will be quite different architecturally.